geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jinmeiliao <...@git.apache.org>
Subject [GitHub] geode pull request #753: GEODE-3283: Expose parallel import and export in gf...
Date Fri, 01 Sep 2017 18:30:45 GMT
Github user jinmeiliao commented on a diff in the pull request:

    https://github.com/apache/geode/pull/753#discussion_r136638437
  
    --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/ImportDataFunction.java
---
    @@ -40,9 +40,13 @@ public void execute(FunctionContext context) {
         final Object[] args = (Object[]) context.getArguments();
         final String regionName = (String) args[0];
         final String importFileName = (String) args[1];
    -    boolean invokeCallbacks = false;
    +    boolean parallel = false;
         if (args.length > 2) {
    --- End diff --
    
    is the args length check necessary? would caller present different args at different times?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message