Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 6AE0F20049D for ; Wed, 9 Aug 2017 22:50:18 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 694D5167C8D; Wed, 9 Aug 2017 20:50:18 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id AEC26167C72 for ; Wed, 9 Aug 2017 22:50:17 +0200 (CEST) Received: (qmail 85942 invoked by uid 500); 9 Aug 2017 20:50:16 -0000 Mailing-List: contact dev-help@geode.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@geode.apache.org Delivered-To: mailing list dev@geode.apache.org Received: (qmail 85931 invoked by uid 99); 9 Aug 2017 20:50:16 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 09 Aug 2017 20:50:16 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 5405EE0202; Wed, 9 Aug 2017 20:50:15 +0000 (UTC) From: YehEmily To: dev@geode.apache.org Reply-To: dev@geode.apache.org Message-ID: Subject: [GitHub] geode pull request #701: GEODE-3337: Refactoring LauncherLifecycleCommandsDU... Content-Type: text/plain Date: Wed, 9 Aug 2017 20:50:15 +0000 (UTC) archived-at: Wed, 09 Aug 2017 20:50:18 -0000 GitHub user YehEmily opened a pull request: https://github.com/apache/geode/pull/701 GEODE-3337: Refactoring LauncherLifecycleCommandsDUnitTest [View the JIRA ticket here.](https://issues.apache.org/jira/browse/GEODE-3337) `LauncherLifecycleCommandsDUnitTest` was a huge test class that tested multiple commands, in addition to using the deprecated `CliCommandsTestBase`. These tests have been refactored to use more up-to-date test rules and also separated into test classes based on the command that they test. Some tests in the original `LauncherLifecycleCommandsDUnitTest` seemed to be unnecessary or redundant (for example, `StatusLocatorRealGfshTest` already tested some of the tests in `LauncherLifecycleCommandsDUnitTest`) so these were deleted. *Testing Status: Precheckin in progress* - [ ] JIRA ticket - [ ] Rebased - [ ] Single commit - [ ] `gradlew build` runs cleanly - [ ] Tests updated You can merge this pull request into a Git repository by running: $ git pull https://github.com/YehEmily/geode GEODE-3337 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/701.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #701 ---- commit c4cdc531c41502d6a162715e324380b66d95794e Author: YehEmily Date: 2017-08-09T17:45:43Z GEODE-3337: Refactoring LauncherLifecycleCommandsDUnitTest ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---