Mailing-List: contact dev-help@geode.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@geode.apache.org
From: gesterzhou <git@git.apache.org>
To: dev@geode.apache.org
Reply-To: dev@geode.apache.org
Message-ID: <git-pr-674-geode@git.apache.org>
Subject: [GitHub] geode pull request #674: GEODE-3380: There're 2 problems here
Content-Type: text/plain
Date: Tue,  1 Aug 2017 01:04:14 +0000 (UTC)
archived-at: Tue, 01 Aug 2017 01:04:17 -0000

GitHub user gesterzhou opened a pull request:

    https://github.com/apache/geode/pull/674

    GEODE-3380: There're 2 problems here

    @dschneider-pivotal @upthewaterspout @boglesby 
    
    There're 2 problems:
    1) when removeAll is retried, it will get EntryNotFound exception. It should still put the remove event
    into the AEQ.
    2) An old bug fix in 8.2 was not merged into develop: when removeAll encounter EntryNotFound exception, should
    return version tag of the tombstone. (i.e. #51871)
    
    Thank you for submitting a contribution to Apache Geode.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    - [ ] Does `gradlew build` run cleanly?
    
    - [ ] Have you written or updated unit tests to verify your changes?
    
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and
    submit an update to your PR as soon as possible. If you need help, please send an
    email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/geode feature/GEODE-3380

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/674.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #674
    
----
commit 2637aaf2677171569c89e98482fb489415795d72
Author: zhouxh <gzhou@pivotal.io>
Date:   2017-08-01T00:55:09Z

    GEODE-3380: There're 2 problems here
    1) when removeAll is retried, it will get EntryNotFound exception. It should still put the remove event
    into the AEQ.
    2) An old bug fix in 8.2 was not merged into develop: when removeAll encounter EntryNotFound exception, should
    return version tag of the tombstone.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---