Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B8DBB200CEC for ; Tue, 1 Aug 2017 02:40:29 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id B7394166062; Tue, 1 Aug 2017 00:40:29 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 305AF16603F for ; Tue, 1 Aug 2017 02:40:29 +0200 (CEST) Received: (qmail 33474 invoked by uid 500); 1 Aug 2017 00:40:23 -0000 Mailing-List: contact dev-help@geode.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@geode.apache.org Delivered-To: mailing list dev@geode.apache.org Received: (qmail 33463 invoked by uid 99); 1 Aug 2017 00:40:23 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Aug 2017 00:40:23 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 2CBECE02F3; Tue, 1 Aug 2017 00:40:21 +0000 (UTC) From: YehEmily To: dev@geode.apache.org Reply-To: dev@geode.apache.org Message-ID: Subject: [GitHub] geode pull request #672: GEODE-3256: Refactoring DataCommands Content-Type: text/plain Date: Tue, 1 Aug 2017 00:40:21 +0000 (UTC) archived-at: Tue, 01 Aug 2017 00:40:29 -0000 GitHub user YehEmily opened a pull request: https://github.com/apache/geode/pull/672 GEODE-3256: Refactoring DataCommands [View the JIRA ticket here.](https://issues.apache.org/jira/browse/GEODE-3256) `DataCommands.java` was a large class that contained multiple commands. Each command was refactored into a separate class, and the methods shared by the commands were refactored into a new and appropriately named class of their own (`DataCommandsUtils`). **Testing Done: Precheckin to be run on morning of 8/1** - [x] JIRA ticket - [x] PR rebased - [x] Single, squashed commit - [x] Does `gradlew build` runs cleanly - [ ] No unit tests updated with this change (yet) - some related tests could stand to be refactored (especially `GemfireDataCommandsDUnitTest`), but I think I will leave these for [GEODE-1359](https://issues.apache.org/jira/browse/GEODE-1359). You can merge this pull request into a Git repository by running: $ git pull https://github.com/YehEmily/geode GEODE-3256 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/672.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #672 ---- commit 017e39eb9cfe27c010c4c31f248c3fcdeab391f9 Author: YehEmily Date: 2017-07-31T23:45:19Z GEODE-3256: Refactoring DataCommands ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---