Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 82140200CE1 for ; Thu, 31 Aug 2017 22:49:22 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 8062716B291; Thu, 31 Aug 2017 20:49:22 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id C776D16B264 for ; Thu, 31 Aug 2017 22:49:21 +0200 (CEST) Received: (qmail 27996 invoked by uid 500); 31 Aug 2017 20:49:20 -0000 Mailing-List: contact dev-help@geode.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@geode.apache.org Delivered-To: mailing list dev@geode.apache.org Received: (qmail 27985 invoked by uid 99); 31 Aug 2017 20:49:20 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 31 Aug 2017 20:49:20 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 78DFBF55AA; Thu, 31 Aug 2017 20:49:20 +0000 (UTC) From: jaredjstewart To: dev@geode.apache.org Reply-To: dev@geode.apache.org References: In-Reply-To: Subject: [GitHub] geode pull request #753: GEODE-3283: Expose parallel import and export in gf... Content-Type: text/plain Message-Id: <20170831204920.78DFBF55AA@git1-us-west.apache.org> Date: Thu, 31 Aug 2017 20:49:20 +0000 (UTC) archived-at: Thu, 31 Aug 2017 20:49:22 -0000 Github user jaredjstewart commented on a diff in the pull request: https://github.com/apache/geode/pull/753#discussion_r136444815 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportDataCommand.java --- @@ -41,44 +44,34 @@ public Result exportData( @CliOption(key = CliStrings.EXPORT_DATA__REGION, mandatory = true, optionContext = ConverterHint.REGION_PATH, help = CliStrings.EXPORT_DATA__REGION__HELP) String regionName, - @CliOption(key = CliStrings.EXPORT_DATA__FILE, mandatory = true, + @CliOption(key = CliStrings.EXPORT_DATA__FILE, help = CliStrings.EXPORT_DATA__FILE__HELP) String filePath, + @CliOption(key = CliStrings.EXPORT_DATA__DIR, + help = CliStrings.EXPORT_DATA__DIR__HELP) String dirPath, @CliOption(key = CliStrings.MEMBER, optionContext = ConverterHint.MEMBERIDNAME, - mandatory = true, help = CliStrings.EXPORT_DATA__MEMBER__HELP) String memberNameOrId) { + mandatory = true, help = CliStrings.EXPORT_DATA__MEMBER__HELP) String memberNameOrId, + @CliOption(key = CliStrings.EXPORT_DATA__PARALLEL, unspecifiedDefaultValue = "false", --- End diff -- I think it would be convenient to the user for us to add `, specifiedDefaultValue = "true" here. That would make it so that one could simply enter `export data --parallel` to get the behavior of `export data --parallel=true`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---