Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 573D32004F1 for ; Wed, 30 Aug 2017 19:38:14 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 55A8C169989; Wed, 30 Aug 2017 17:38:14 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id A5F23169986 for ; Wed, 30 Aug 2017 19:38:13 +0200 (CEST) Received: (qmail 76858 invoked by uid 500); 30 Aug 2017 17:38:11 -0000 Mailing-List: contact dev-help@geode.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@geode.apache.org Delivered-To: mailing list dev@geode.apache.org Received: (qmail 76847 invoked by uid 99); 30 Aug 2017 17:38:11 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 30 Aug 2017 17:38:11 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 9C3341828F1; Wed, 30 Aug 2017 17:38:10 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3 X-Spam-Level: *** X-Spam-Status: No, score=3 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id Voha5sBG2tge; Wed, 30 Aug 2017 17:38:09 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 6DFC45F245; Wed, 30 Aug 2017 17:38:08 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 25C5AE06BD; Wed, 30 Aug 2017 17:38:06 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id BF9E1C411E7; Wed, 30 Aug 2017 17:38:04 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1396905756855326254==" MIME-Version: 1.0 Subject: Review Request 61995: wip From: Jinmei Liao To: Kirk Lund , Patrick Rhomberg , Emily Yeh , Jared Stewart , Ken Howe Cc: Jinmei Liao , geode Date: Wed, 30 Aug 2017 17:38:03 -0000 Message-ID: <20170830173803.20155.53068@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Jinmei Liao X-ReviewGroup: geode X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/61995/ X-Sender: Jinmei Liao X-ReviewBoard-Diff-For: geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/GfshCommandIntegrationTest.java X-ReviewBoard-Diff-For: geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/StartMemberUtilsTest.java X-ReviewBoard-Diff-For: geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/GemfireCoreClasspathTest.java X-ReviewBoard-Diff-For: geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/GfshCommandIntegrationTest.java Reply-To: Jinmei Liao X-ReviewRequest-Repository: geode archived-at: Wed, 30 Aug 2017 17:38:14 -0000 --===============1396905756855326254== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61995/ ----------------------------------------------------------- Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Patrick Rhomberg. Repository: geode Description ------- GEODE-3539: add test for invalid command * also rework GfshCommandIntegrationTest in assembly module Diffs ----- geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/GfshCommandIntegrationTest.java 263b12cbdee2bc5637e64fdad0e34262ab5f25e7 geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/GfshCommandIntegrationTest.java PRE-CREATION geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/StartMemberUtilsTest.java PRE-CREATION Diff: https://reviews.apache.org/r/61995/diff/1/ Testing ------- precheckin running Thanks, Jinmei Liao --===============1396905756855326254==--