Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 32AEE167454 for ; Tue, 22 Aug 2017 19:16:37 +0200 (CEST) Received: (qmail 70591 invoked by uid 500); 22 Aug 2017 17:16:35 -0000 Mailing-List: contact dev-help@geode.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@geode.apache.org Delivered-To: mailing list dev@geode.apache.org Received: (qmail 70580 invoked by uid 99); 22 Aug 2017 17:16:35 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 Aug 2017 17:16:35 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 970911A02DA; Tue, 22 Aug 2017 17:16:34 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3 X-Spam-Level: *** X-Spam-Status: No, score=3 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id cvphZmqAuJSI; Tue, 22 Aug 2017 17:16:33 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 44B4F5F520; Tue, 22 Aug 2017 17:16:33 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id E737FE01E5; Tue, 22 Aug 2017 17:16:32 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id F13EDC4036F; Tue, 22 Aug 2017 17:16:31 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2343383426958439236==" MIME-Version: 1.0 Subject: Review Request 61816: GEODE-3409 Protobuf Client Can't Connect Once Connection Limit Has Been Reached, Even After Connections Closed From: Bruce Schuchardt To: Udo Kohlmeyer , Galen O'Sullivan , Hitesh Khamesra , Brian Rowe , Alexander Murmann Cc: geode , Bruce Schuchardt Date: Tue, 22 Aug 2017 17:16:30 -0000 Message-ID: <20170822171630.1763.17591@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Bruce Schuchardt X-ReviewGroup: geode X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/61816/ X-Sender: Bruce Schuchardt Reply-To: Bruce Schuchardt X-ReviewRequest-Repository: geode --===============2343383426958439236== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61816/ ----------------------------------------------------------- Review request for geode, Alexander Murmann, Galen O'Sullivan, Hitesh Khamesra, Udo Kohlmeyer, and Brian Rowe. Bugs: GEODE-3409 https://issues.apache.org/jira/browse/GEODE-3409 Repository: geode Description ------- ServerConnection cleanup was not decrementing the Acceptor's client connection count when the protobuf communications mode was in effect. Diffs ----- geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ClientHealthMonitor.java 35cc33f geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnection.java 394d261 geode-protobuf/src/test/java/org/apache/geode/protocol/RoundTripCacheConnectionJUnitTest.java 12cc08b Diff: https://reviews.apache.org/r/61816/diff/1/ Testing ------- new integration test Thanks, Bruce Schuchardt --===============2343383426958439236==--