Mailing-List: contact dev-help@geode.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@geode.apache.org
From: galen-pivotal <git@git.apache.org>
To: dev@geode.apache.org
Reply-To: dev@geode.apache.org
References: <git-pr-716-geode@git.apache.org>
In-Reply-To: <git-pr-716-geode@git.apache.org>
Subject: [GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests
Content-Type: text/plain
Message-Id: <20170822000608.205C7E7DFA@git1-us-west.apache.org>
Date: Tue, 22 Aug 2017 00:06:08 +0000 (UTC)

Github user galen-pivotal commented on a diff in the pull request:

    https://github.com/apache/geode/pull/716#discussion_r134270934
  
    --- Diff: geode-core/src/test/java/org/apache/geode/test/dunit/standalone/DUnitLauncher.java ---
    @@ -297,6 +297,8 @@ public Object call() throws IOException {
             // able to do so successfully anyway
             p.setProperty(DISABLE_AUTO_RECONNECT, "true");
     
    +        System.setProperty("geode.feature-protobuf-protocol", "true");
    --- End diff --
    
    Do we want to do this for all DUnit tests? On the one hand, it might help shake some bugs out; on the other, we're setting a system property for all tests.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---