Mailing-List: contact dev-help@geode.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@geode.apache.org
From: pivotal-amurmann <git@git.apache.org>
To: dev@geode.apache.org
Reply-To: dev@geode.apache.org
References: <git-pr-700-geode@git.apache.org>
In-Reply-To: <git-pr-700-geode@git.apache.org>
Subject: [GitHub] geode pull request #700: GEODE-3386 - Make KeyedErrorResponse & ErrorRespons...
Content-Type: text/plain
Message-Id: <20170814164441.01A9FE96E9@git1-us-west.apache.org>
Date: Mon, 14 Aug 2017 16:44:41 +0000 (UTC)
archived-at: Mon, 14 Aug 2017 16:44:43 -0000

Github user pivotal-amurmann commented on a diff in the pull request:

    https://github.com/apache/geode/pull/700#discussion_r133000153
  
    --- Diff: geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetAllRequestOperationHandler.java ---
    @@ -59,13 +59,14 @@
           }
           return Success.of(RegionAPI.GetAllResponse.newBuilder().addAllEntries(entries).build());
         } catch (UnsupportedEncodingTypeException ex) {
    -      return Failure.of(BasicTypes.ErrorResponse.newBuilder()
    -          .setErrorCode(ProtocolErrorCode.VALUE_ENCODING_ERROR.codeValue)
    -          .setMessage("Encoding not supported.").build());
    +      int errorCode = ProtocolErrorCode.VALUE_ENCODING_ERROR.codeValue;
    +      String message = "Encoding not supported.";
    +      return Failure.of(ProtobufResponseUtilities.makeErrorResponse(errorCode, message));
    --- End diff --
    
    good catch! The variables were supposed to be temporary to enable IntelliJ's refactoring.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---