Mailing-List: contact dev-help@geode.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@geode.apache.org
From: kirklund <git@git.apache.org>
To: dev@geode.apache.org
Reply-To: dev@geode.apache.org
References: <git-pr-699-geode@git.apache.org>
In-Reply-To: <git-pr-699-geode@git.apache.org>
Subject: [GitHub] geode pull request #699: GEODE-3413: overhaul launcher and process classes a...
Content-Type: text/plain
Message-Id: <20170810231836.37E3EE3C41@git1-us-west.apache.org>
Date: Thu, 10 Aug 2017 23:18:36 +0000 (UTC)
archived-at: Thu, 10 Aug 2017 23:18:38 -0000

Github user kirklund commented on a diff in the pull request:

    https://github.com/apache/geode/pull/699#discussion_r132592102
  
    --- Diff: geode-core/src/test/java/org/apache/geode/internal/process/NonBlockingProcessStreamReaderIntegrationTest.java ---
    @@ -0,0 +1,182 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more contributor license
    + * agreements. See the NOTICE file distributed with this work for additional information regarding
    + * copyright ownership. The ASF licenses this file to You under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance with the License. You may obtain a
    + * copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software distributed under the License
    + * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
    + * or implied. See the License for the specific language governing permissions and limitations under
    + * the License.
    + */
    +package org.apache.geode.internal.process;
    +
    +import static org.apache.geode.internal.process.ProcessStreamReader.ReadingMode.NON_BLOCKING;
    +import static org.apache.geode.internal.process.ProcessUtils.isProcessAlive;
    +import static org.assertj.core.api.Assertions.assertThat;
    +
    +import org.junit.Before;
    +import org.junit.Test;
    +import org.junit.experimental.categories.Category;
    +
    +import org.apache.geode.internal.process.ProcessStreamReader.Builder;
    +import org.apache.geode.test.junit.categories.IntegrationTest;
    +
    +/**
    + * Functional integration tests for NonBlockingProcessStreamReader which was introduced to fix TRAC
    + * #51967.
    + *
    + * @see BlockingProcessStreamReaderIntegrationTest
    + * @see BlockingProcessStreamReaderWindowsTest
    + *
    + * @since GemFire 8.2
    + */
    +@Category(IntegrationTest.class)
    +public class NonBlockingProcessStreamReaderIntegrationTest
    +    extends BaseProcessStreamReaderIntegrationTest {
    +
    +  private StringBuffer stdoutBuffer;
    +  private StringBuffer stderrBuffer;
    +
    +  @Before
    +  public void before() {
    +    stdoutBuffer = new StringBuffer();
    +    stderrBuffer = new StringBuffer();
    +  }
    +
    +  /**
    +   * This test hangs on Windows if the implementation is blocking instead of non-blocking.
    +   */
    +  @Test
    +  public void canCloseStreamsWhileProcessIsAlive() throws Exception {
    +    // arrange
    +    process = new ProcessBuilder(createCommandLine(ProcessSleeps.class)).start();
    +    stdout = new Builder(process).inputStream(process.getInputStream()).readingMode(NON_BLOCKING)
    +        .build().start();
    +    stderr = new Builder(process).inputStream(process.getErrorStream()).readingMode(NON_BLOCKING)
    --- End diff --
    
    Done.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---