Mailing-List: contact dev-help@geode.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@geode.apache.org
From: kirklund <git@git.apache.org>
To: dev@geode.apache.org
Reply-To: dev@geode.apache.org
References: <git-pr-699-geode@git.apache.org>
In-Reply-To: <git-pr-699-geode@git.apache.org>
Subject: [GitHub] geode pull request #699: GEODE-3413: overhaul launcher and process classes a...
Content-Type: text/plain
Message-Id: <20170809211447.D234AE382D@git1-us-west.apache.org>
Date: Wed,  9 Aug 2017 21:14:47 +0000 (UTC)
archived-at: Wed, 09 Aug 2017 21:14:51 -0000

Github user kirklund commented on a diff in the pull request:

    https://github.com/apache/geode/pull/699#discussion_r132308711
  
    --- Diff: geode-core/src/test/java/org/apache/geode/distributed/AbstractLauncherIntegrationTest.java ---
    @@ -47,26 +50,21 @@
     
       @Before
       public void setUp() throws Exception {
    -    this.gemfirePropertiesFile =
    -        this.temporaryFolder.newFile(DistributionConfig.GEMFIRE_PREFIX + "properties");
    +    propertiesFile = temporaryFolder.newFile(GEMFIRE_PREFIX + "properties");
     
    -    this.expectedGemfireProperties = new Properties();
    -    this.expectedGemfireProperties.setProperty(NAME, "memberOne");
    -    this.expectedGemfireProperties.setProperty(GROUPS, "groupOne, groupTwo");
    -    this.expectedGemfireProperties.store(new FileWriter(this.gemfirePropertiesFile, false),
    -        this.testName.getMethodName());
    +    expectedProperties = new Properties();
    +    expectedProperties.setProperty(NAME, "memberOne");
    +    expectedProperties.setProperty(GROUPS, "groupOne, groupTwo");
    +    expectedProperties.store(new FileWriter(propertiesFile, false), testName.getMethodName());
     
    -    assertThat(this.gemfirePropertiesFile).isNotNull();
    -    assertThat(this.gemfirePropertiesFile.exists()).isTrue();
    -    assertThat(this.gemfirePropertiesFile.isFile()).isTrue();
    +    assertThat(propertiesFile).exists().isFile();
       }
     
       @Test
    -  public void testLoadGemFirePropertiesFromFile() throws Exception {
    -    final Properties actualGemFireProperties =
    -        AbstractLauncher.loadGemFireProperties(this.gemfirePropertiesFile.toURI().toURL());
    +  public void loadGemFirePropertiesFromFile() throws Exception {
    +    Properties loadedProperties = loadGemFireProperties(propertiesFile.toURI().toURL());
     
    -    assertThat(actualGemFireProperties).isNotNull();
    -    assertThat(actualGemFireProperties).isEqualTo(this.expectedGemfireProperties);
    +    assertThat(loadedProperties).isEqualTo(expectedProperties);
       }
    +
    --- End diff --
    
    Removed from all classes in change-set.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---