Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id F1736200CD9 for ; Thu, 3 Aug 2017 20:04:02 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id EE63816C357; Thu, 3 Aug 2017 18:04:02 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 47A6516C355 for ; Thu, 3 Aug 2017 20:04:02 +0200 (CEST) Received: (qmail 7980 invoked by uid 500); 3 Aug 2017 18:03:55 -0000 Mailing-List: contact dev-help@geode.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@geode.apache.org Delivered-To: mailing list dev@geode.apache.org Received: (qmail 7968 invoked by uid 99); 3 Aug 2017 18:03:55 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Aug 2017 18:03:55 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id B8975C0286; Thu, 3 Aug 2017 18:03:54 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 4.451 X-Spam-Level: **** X-Spam-Status: No, score=4.451 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, NML_ADSP_CUSTOM_MED=1.2, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 9nyeuhD2x6YU; Thu, 3 Aug 2017 18:03:53 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id A13CD5F6C8; Thu, 3 Aug 2017 18:03:52 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id EF185E0012; Thu, 3 Aug 2017 18:03:51 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 87224C40126; Thu, 3 Aug 2017 18:03:49 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3437804655969138184==" MIME-Version: 1.0 Subject: Re: Review Request 61409: GEODE-3328: simplify GfshParserRule From: Kirk Lund To: Kirk Lund , Patrick Rhomberg , Emily Yeh , Jared Stewart , Ken Howe Cc: Jinmei Liao , geode Date: Thu, 03 Aug 2017 18:03:48 -0000 Message-ID: <20170803180348.25951.73573@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Kirk Lund X-ReviewGroup: geode X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/61409/ X-Sender: Kirk Lund X-ReviewBoard-ShipIt: 1 References: <20170803171243.25995.89741@reviews-vm2.apache.org> In-Reply-To: <20170803171243.25995.89741@reviews-vm2.apache.org> X-ReviewBoard-ShipIt-Only: 1 Reply-To: Kirk Lund X-ReviewRequest-Repository: geode archived-at: Thu, 03 Aug 2017 18:04:03 -0000 --===============3437804655969138184== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61409/#review182131 ----------------------------------------------------------- Ship it! Ship It! - Kirk Lund On Aug. 3, 2017, 5:12 p.m., Jinmei Liao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61409/ > ----------------------------------------------------------- > > (Updated Aug. 3, 2017, 5:12 p.m.) > > > Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Patrick Rhomberg. > > > Repository: geode > > > Description > ------- > > GEODE-3328: simplify GfshParserRule > > another step towards refactor connect command, some simple rule change. > > > Diffs > ----- > > geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/StartLocatorCommandIntegrationTest.java 0700742fac70730c160d28c62c93b824e8ee0a3c > geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/StartServerCommandIntegrationTest.java 059611dc1c5101643cbae18d067a2943a573d405 > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/CreateAlterDestroyRegionCommandsTest.java c2810801257479ad9a31452f294daaaf2975dfad > geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshParserRule.java b1bc7aa73b7d9273ad9a89af4c119d91a67aae03 > > > Diff: https://reviews.apache.org/r/61409/diff/1/ > > > Testing > ------- > > precheckin running, tests > > > Thanks, > > Jinmei Liao > > --===============3437804655969138184==--