Mailing-List: contact dev-help@geode.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@geode.apache.org
From: jinmeiliao <git@git.apache.org>
To: dev@geode.apache.org
Reply-To: dev@geode.apache.org
References: <git-pr-664-geode@git.apache.org>
In-Reply-To: <git-pr-664-geode@git.apache.org>
Subject: [GitHub] geode pull request #664: Fix for GEODE-3292
Content-Type: text/plain
Message-Id: <20170803041133.F2762DFA3C@git1-us-west.apache.org>
Date: Thu,  3 Aug 2017 04:11:33 +0000 (UTC)
archived-at: Thu, 03 Aug 2017 04:11:37 -0000

Github user jinmeiliao commented on a diff in the pull request:

    https://github.com/apache/geode/pull/664#discussion_r131049401
  
    --- Diff: geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseConnectivityTest.java ---
    @@ -0,0 +1,110 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more contributor license
    + * agreements. See the NOTICE file distributed with this work for additional information regarding
    + * copyright ownership. The ASF licenses this file to You under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance with the License. You may obtain a
    + * copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software distributed under the License
    + * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
    + * or implied. See the License for the specific language governing permissions and limitations under
    + * the License.
    + */
    +
    +package org.apache.geode.tools.pulse;
    +
    +import static org.apache.geode.distributed.ConfigurationProperties.JMX_MANAGER_BIND_ADDRESS;
    +import static org.assertj.core.api.Assertions.assertThat;
    +
    +import java.net.InetAddress;
    +import java.util.Properties;
    +
    +import org.apache.geode.test.dunit.rules.EmbeddedPulseRule;
    +import org.apache.geode.test.dunit.rules.LocatorStarterRule;
    +import org.apache.geode.test.junit.categories.IntegrationTest;
    +import org.apache.geode.tools.pulse.internal.data.Cluster;
    +import org.junit.AfterClass;
    +import org.junit.BeforeClass;
    +import org.junit.ClassRule;
    +import org.junit.Rule;
    +import org.junit.Test;
    +import org.junit.experimental.categories.Category;
    +import org.junit.experimental.runners.Enclosed;
    +import org.junit.runner.RunWith;
    +
    +@RunWith(Enclosed.class)
    --- End diff --
    
    I am not sure I've seen this pattern before. It looks like you are adding another set of test to the original PulseVerificationTest. I believe another separate test class would read better. I would leave the original test alone (since it has a test that uses httpClient to try to connect with a wrong password). 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---