Mailing-List: contact dev-help@geode.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@geode.apache.org
From: pdxrunner <git@git.apache.org>
To: dev@geode.apache.org
Reply-To: dev@geode.apache.org
References: <git-pr-651-geode@git.apache.org>
In-Reply-To: <git-pr-651-geode@git.apache.org>
Subject: [GitHub] geode pull request #651: GEODE-3230: Cleaning up unused (Cli)Strings
Content-Type: text/plain
Message-Id: <20170802200845.E5D53E00C5@git1-us-west.apache.org>
Date: Wed,  2 Aug 2017 20:08:45 +0000 (UTC)
archived-at: Wed, 02 Aug 2017 20:08:53 -0000

Github user pdxrunner commented on a diff in the pull request:

    https://github.com/apache/geode/pull/651#discussion_r130982335
  
    --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/DataCommandFunction.java ---
    @@ -633,8 +631,8 @@ public DataCommandResult put(String key, String value, boolean putIfAbsent, Stri
           try {
             keyObject = getClassObject(key, keyClass);
           } catch (ClassNotFoundException e) {
    -        return DataCommandResult.createPutResult(key, null, null,
    -            "ClassNotFoundException " + keyClass, false);
    +        return DataCommandResult.createPutResult(key, null, e.getException(),
    --- End diff --
    
    I don't understand the context of this change - the message was "ClassNotFound" but now it's "key not found" with a key class? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---