geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ladyVader <...@git.apache.org>
Subject [GitHub] geode pull request #744: GEODE-3522: create via load needs to add event to A...
Date Fri, 25 Aug 2017 21:55:17 GMT
GitHub user ladyVader opened a pull request:

    https://github.com/apache/geode/pull/744

    GEODE-3522: create via load needs to add event to AEQ under same lock…

    … as update to local region
    
    * create via load was invoking handleWANEvent prior to obtaining a lock, which allowed
rebalance to
      shift the primary between AEQ update and data region update.
    * moved call to handleWANEvent from DistributedRegion to BucketRegion to synchronize these
two actions.
    
    @upthewaterspout, @boglesby
    
    Thank you for submitting a contribution to Apache Geode.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically
`develop`)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    - [ ] Does `gradlew build` run cleanly?
    
    - [ ] Have you written or updated unit tests to verify your changes?
    
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way
that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and
    submit an update to your PR as soon as possible. If you need help, please send an
    email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/geode feature/GEODE-3522

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/744.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #744
    
----
commit afbfd708185cc7ed82490699c033c40263e4aa76
Author: Lynn Hughes-Godfrey <lhughesgodfrey@pivotal.io>
Date:   2017-08-25T21:46:17Z

    GEODE-3522: create via load needs to add event to AEQ under same lock as update to local
region
    
    * create via load was invoking handleWANEvent prior to obtaining a lock, which allowed
rebalance to
      shift the primary between AEQ update and data region update.
    * moved call to handleWANEvent from DistributedRegion to BucketRegion to synchronize these
two actions.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message