geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From galen-pivotal <...@git.apache.org>
Subject [GitHub] geode pull request #739: GEODE-3385: Change GetAllRequest to return list of ...
Date Wed, 23 Aug 2017 21:55:48 GMT
GitHub user galen-pivotal opened a pull request:

    https://github.com/apache/geode/pull/739

    GEODE-3385: Change GetAllRequest to return list of errors.

    Also:
    * Rename `KeyedErrorResponse` to `KeyedError`.
    * move `ErrorResponse` to `clientProtocol.proto`.
    * Check for null value in `ProtobufUtilities.createEntry`.
      If we find a null, we don't set the value; previously this resulted in
    NPE.
    
    Signed-off-by: Galen O'Sullivan <gosullivan@pivotal.io>
    
    Thank you for submitting a contribution to Apache Geode.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically
`develop`)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    - [x] Does `gradlew build` run cleanly?
    
    - [x] Have you written or updated unit tests to verify your changes?
    
    - [n/a] If adding new dependencies to the code, are these dependencies licensed in a way
that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and
    submit an update to your PR as soon as possible. If you need help, please send an
    email to dev@geode.apache.org.
    
    @WireBaron @bschuchardt @hiteshk25 @kohlmu-pivotal @pivotal-amurmann 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/galen-pivotal/geode feature/GEODE-3385

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/739.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #739
    
----
commit 78514a41718fb2682780bb949cf8ee4efb76224b
Author: Brian Rowe <browe@pivotal.io>
Date:   2017-08-23T21:53:06Z

    GEODE-3385: Change GetAllRequest to return list of errors.
    
    Also:
    * Rename `KeyedErrorResponse` to `KeyedError`.
    * move `ErrorResponse` to `clientProtocol.proto`.
    * Check for null value in `ProtobufUtilities.createEntry`.
      If we find a null, we don't set the value; previously this resulted in
    NPE.
    
    Signed-off-by: Galen O'Sullivan <gosullivan@pivotal.io>

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message