geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kirklund <...@git.apache.org>
Subject [GitHub] geode pull request #738: GEODE-3506: improve validation/error checking for p...
Date Wed, 23 Aug 2017 21:38:18 GMT
GitHub user kirklund opened a pull request:

    https://github.com/apache/geode/pull/738

    GEODE-3506: improve validation/error checking for process file control

    We only ever hit this failure once and I don't think it's a flaky test. This could actually
be one more (last remaining?) root cause of "start locator" or "start server" hanging-while-printing-dots
in GFSH. 
    
    I've added what I consider to be excessive validation and error checking but it should
point us at the cause if this check in FileProcessController ever fails again:
    
        if (isBlank(lines)) {
          throw new IllegalStateException("Status file '" + statusFile + "' is blank");
        }
    
    In addition to this PR, we should consider adding more direct test coverage for ServiceState
and its subclasses as well as more unit tests of the Launcher using mocks.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kirklund/geode GEODE-3506-FileProcessController

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/738.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #738
    
----
commit 8edd3f0e15406082bb568de975c631de2ae373d7
Author: Kirk Lund <klund@apache.org>
Date:   2017-08-23T21:20:18Z

    GEODE-3506: improve validation and error handling of process file control

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message