geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From YehEmily <...@git.apache.org>
Subject [GitHub] geode pull request #701: GEODE-3337: Refactoring LauncherLifecycleCommandsDU...
Date Wed, 09 Aug 2017 20:50:15 GMT
GitHub user YehEmily opened a pull request:

    https://github.com/apache/geode/pull/701

    GEODE-3337: Refactoring LauncherLifecycleCommandsDUnitTest

    [View the JIRA ticket here.](https://issues.apache.org/jira/browse/GEODE-3337)
    
    `LauncherLifecycleCommandsDUnitTest` was a huge test class that tested multiple commands,
in addition to using the deprecated `CliCommandsTestBase`. These tests have been refactored
to use more up-to-date test rules and also separated into test classes based on the command
that they test.
    
    Some tests in the original `LauncherLifecycleCommandsDUnitTest` seemed to be unnecessary
or redundant (for example, `StatusLocatorRealGfshTest` already tested some of the tests in
`LauncherLifecycleCommandsDUnitTest`) so these were deleted.
    
    *Testing Status: Precheckin in progress*
    
    - [ ] JIRA ticket
    
    - [ ] Rebased
    
    - [ ] Single commit
    
    - [ ] `gradlew build` runs cleanly
    
    - [ ] Tests updated

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/YehEmily/geode GEODE-3337

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/701.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #701
    
----
commit c4cdc531c41502d6a162715e324380b66d95794e
Author: YehEmily <emilyyeh1997@gmail.com>
Date:   2017-08-09T17:45:43Z

    GEODE-3337: Refactoring LauncherLifecycleCommandsDUnitTest

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message