geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From YehEmily <...@git.apache.org>
Subject [GitHub] geode pull request #691: GEODE-3260: Refactoring FunctionCommands
Date Mon, 07 Aug 2017 20:01:37 GMT
GitHub user YehEmily opened a pull request:

    https://github.com/apache/geode/pull/691

    GEODE-3260: Refactoring FunctionCommands

    [View the JIRA ticket here.](https://issues.apache.org/jira/browse/GEODE-3260)
    
    `FunctionCommands` was a huge class that contained a large number of commands. These commands
have been split into their own individual command classes.
    
    **TESTING STATUS: Precheckin in progress**
    
    - [x] JIRA ticket referenced
    
    - [x] PR rebased
    
    - [x] Initial commit is single and squashed
    
    - [x] `gradlew build` runs cleanly
    
    - [ ] Unit tests will be updated with [GEODE-1359](https://issues.apache.org/jira/browse/GEODE-1359))

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/YehEmily/geode GEODE-3260

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/691.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #691
    
----
commit 0265b29cc104e0b166dc5972bf739f042276cb5b
Author: YehEmily <emilyyeh1997@gmail.com>
Date:   2017-08-07T19:56:17Z

    GEODE-3260: Refactoring FunctionCommands

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message