geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From anton-mironenko <...@git.apache.org>
Subject [GitHub] geode pull request #677: GEODE-3038: A server process shuts down quietly whe...
Date Wed, 02 Aug 2017 14:40:44 GMT
GitHub user anton-mironenko opened a pull request:

    https://github.com/apache/geode/pull/677

    GEODE-3038: A server process shuts down quietly when path to cache.xml is incorrect

    [GEODE-3038](https://issues.apache.org/jira/browse/GEODE-3038)
    The error 
    "Declarative Cache XML file/resource \[path-to-cache-xml\] does not exist"
    is trying to be written into the log in GemFireCacheImpl.basicCreate(), after method GemFireCacheImpl.close()
is called, so that writing into the log is already not available.
    
    Thank you for submitting a contribution to Apache Geode.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically
`develop`)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    - [x] Does `gradlew build` run cleanly?
    
    - [ ] Have you written or updated unit tests to verify your changes?
    
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way
that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and
    submit an update to your PR as soon as possible. If you need help, please send an
    email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/anton-mironenko/geode develop

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/677.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #677
    
----
commit f119fb381d4212e8714d26f2388860206daa3d8a
Author: Anton Mironenko <anton.mironenko@gmail.com>
Date:   2017-08-01T12:18:12Z

    write cachexml-not-found exception into the log in a proper place

commit bf0b059035751b3d7cba82a145546edb7efce824
Author: Anton Mironenko <anton.mironenko@gmail.com>
Date:   2017-08-01T12:52:14Z

    Merge remote-tracking branch 'upstream/develop' into GEODE-3038

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message