geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From YehEmily <...@git.apache.org>
Subject [GitHub] geode pull request #675: GEODE-3339: Refactoring ClusterConfigurationService...
Date Tue, 01 Aug 2017 17:33:55 GMT
GitHub user YehEmily opened a pull request:

    https://github.com/apache/geode/pull/675

    GEODE-3339: Refactoring ClusterConfigurationServiceEndToEndDUnitTest

    [View the JIRA ticket here.](https://issues.apache.org/jira/browse/GEODE-3339)
    
    ClusterConfigurationServiceEndToEndDUnitTest has been refactored to use test rules instead
of CliCommandsTestBase, and a version of the test that uses HTTP connection was also added.
    
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically
`develop`)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    - [x] Does `gradlew build` run cleanly?
    
    - [x] Have you written or updated unit tests to verify your changes?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/YehEmily/geode GEODE-3339

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/675.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #675
    
----
commit 1f9ad5523bd04706cc96a48db990b4452548a7da
Author: YehEmily <emilyyeh1997@gmail.com>
Date:   2017-08-01T17:30:09Z

    GEODE-3339: Refactoring ClusterConfigurationServiceEndToEndDUnitTest

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message