geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Kimura <dkim...@pivotal.io>
Subject [DISCUSS] geode-native c++ exceptions
Date Thu, 17 Aug 2017 18:57:12 GMT
C++ client uses a custom standalone base exception class [1
<https://github.com/apache/geode-native/blob/develop/cppcache/include/geode/Exception.hpp#L45-L123>]
and several derived exceptions [2
<https://github.com/apache/geode-native/blob/develop/cppcache/include/geode/ExceptionTypes.hpp#L70-L393>
].

Using exceptions seems contrary to the Google C++ Style Guide we adopted,
which states: *"do not use C++ exceptions"* [3
<https://google.github.io/styleguide/cppguide.html#Exceptions>].  Here is a
link [4 <https://www.youtube.com/watch?v=NOCElcMcFik#t=30m29s>] to a cppcon
talk defending their decision.  Does it make sense to enforce this rule on
our code base?

If we decide to knowingly ignore this rule, would we want to continue to
propagate custom exceptions or switch to standard exceptions?  At the very
least, it seems to me that our custom exceptions should derive from their
most closely matching standard exception counterparts.  Thoughts?

Thanks,
David

[1] https://github.com/apache/geode-native/blob/develop/cppcache
/include/geode/Exception.hpp#L45-L123
[2] https://github.com/apache/geode-native/blob/develop/cppcache
/include/geode/ExceptionTypes.hpp#L70-L393
[3] https://google.github.io/styleguide/cppguide.html#Exceptions
[4] https://www.youtube.com/watch?v=NOCElcMcFik#t=30m29s

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message