geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jaredjstewart <...@git.apache.org>
Subject [GitHub] geode pull request #753: GEODE-3283: Expose parallel import and export in gf...
Date Thu, 31 Aug 2017 20:49:20 GMT
Github user jaredjstewart commented on a diff in the pull request:

    https://github.com/apache/geode/pull/753#discussion_r136444815
  
    --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportDataCommand.java
---
    @@ -41,44 +44,34 @@ public Result exportData(
           @CliOption(key = CliStrings.EXPORT_DATA__REGION, mandatory = true,
               optionContext = ConverterHint.REGION_PATH,
               help = CliStrings.EXPORT_DATA__REGION__HELP) String regionName,
    -      @CliOption(key = CliStrings.EXPORT_DATA__FILE, mandatory = true,
    +      @CliOption(key = CliStrings.EXPORT_DATA__FILE,
               help = CliStrings.EXPORT_DATA__FILE__HELP) String filePath,
    +      @CliOption(key = CliStrings.EXPORT_DATA__DIR,
    +          help = CliStrings.EXPORT_DATA__DIR__HELP) String dirPath,
           @CliOption(key = CliStrings.MEMBER, optionContext = ConverterHint.MEMBERIDNAME,
    -          mandatory = true, help = CliStrings.EXPORT_DATA__MEMBER__HELP) String memberNameOrId)
{
    +          mandatory = true, help = CliStrings.EXPORT_DATA__MEMBER__HELP) String memberNameOrId,
    +      @CliOption(key = CliStrings.EXPORT_DATA__PARALLEL, unspecifiedDefaultValue = "false",
    --- End diff --
    
    I think it would be convenient to the user for us to add `, specifiedDefaultValue = "true"
here.  That would make it so that one could simply enter `export data --parallel` to get the
behavior of `export data --parallel=true`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message