geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jared Stewart <jstew...@pivotal.io>
Subject Re: Review Request 61972: GEODE-3445: Convert connect acceptance test to DUnit test
Date Tue, 29 Aug 2017 20:47:40 GMT


> On Aug. 29, 2017, 6:42 p.m., Patrick Rhomberg wrote:
> > As an aside, I assume you post these things via script.  You're still tagging `eyeh`.
 Not that it really matters, since it's hooked ot a `pivotal` email, but still worth updating.
> 
> Patrick Rhomberg wrote:
>     Also looks like you're not tagging Jinmei or Swap.

Thanks, I updated my .reviewboardrc!


- Jared


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61972/#review184081
-----------------------------------------------------------


On Aug. 29, 2017, 4:53 p.m., Jared Stewart wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61972/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2017, 4:53 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Patrick
Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> GEODE-3445: Convert connect w/ http & ssl acceptance test to DUnit test
> 
> 
> Diffs
> -----
> 
>   geode-assembly/src/test/java/org/apache/geode/management/GfshConnectToLocatorWithSSLAcceptanceTest.java
75d60a32411582d75eb0f5cacce1536a6f724a26 
>   geode-web/src/test/java/org/apache/geode/management/internal/cli/commands/ConnectCommandWithSSLTest.java
7c4fb446ca4909c628010087b7c85aa121883894 
> 
> 
> Diff: https://reviews.apache.org/r/61972/diff/1/
> 
> 
> Testing
> -------
> 
> Precheckin passed
> 
> 
> Thanks,
> 
> Jared Stewart
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message