geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pivotal-amurmann <...@git.apache.org>
Subject [GitHub] geode pull request #719: GEODE-3447 Implement client authorization for the n...
Date Thu, 24 Aug 2017 23:30:01 GMT
Github user pivotal-amurmann commented on a diff in the pull request:

    https://github.com/apache/geode/pull/719#discussion_r135153452
  
    --- Diff: geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufOpsProcessor.java
---
    @@ -44,9 +46,15 @@ public ProtobufOpsProcessor(SerializationService serializationService,
         ClientProtocol.Response.Builder builder;
         Result result;
         try {
    -      result = operationContext.getOperationHandler().process(serializationService,
    -          operationContext.getFromRequest().apply(request), context);
    -    } catch (InvalidExecutionContextException e) {
    +      if (context.getAuthorizer().authorize(operationContext.getAccessPermissionRequired()))
{
    +        result = operationContext.getOperationHandler().process(serializationService,
    +            operationContext.getFromRequest().apply(request), context);
    +      } else {
    --- End diff --
    
    We might want to log this. Logging all security related events can be a life saver during
or after a security incident.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message