geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jaredjstewart <...@git.apache.org>
Subject [GitHub] geode pull request #730: GEODE-3472: Remove a great deal of commented-out co...
Date Wed, 23 Aug 2017 21:15:44 GMT
Github user jaredjstewart commented on a diff in the pull request:

    https://github.com/apache/geode/pull/730#discussion_r134869699
  
    --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/CliUtil.java
---
    @@ -212,8 +211,7 @@ public static void bytesToFiles(byte[][] fileData, String parentDirPath,
boolean
       }
     
       public static boolean isValidFileName(String filePath, String extension) {
    -    boolean isValid = true;
    -    return isValid;
    +    return true;
    --- End diff --
    
    Can we just delete this method entirely?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message