geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Udo Kohlmeyer <ukohlme...@gmail.com>
Subject Re: Review Request 61829: GEODE-3408 Flood of EOF warnings
Date Wed, 23 Aug 2017 16:49:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61829/#review183620
-----------------------------------------------------------


Ship it!




Ship It!

- Udo Kohlmeyer


On Aug. 22, 2017, 11:41 p.m., Bruce Schuchardt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61829/
> -----------------------------------------------------------
> 
> (Updated Aug. 22, 2017, 11:41 p.m.)
> 
> 
> Review request for geode, Alexander Murmann, Galen O'Sullivan, Hitesh Khamesra, Udo Kohlmeyer,
and Brian Rowe.
> 
> 
> Bugs: GEODE-3408
>     https://issues.apache.org/jira/browse/GEODE-3408
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> Modified the message handler to catch EOFException and effect shutdown of the connection
& server thread.  I also fixed the handling of IOException.
> 
> The methods invoked are the same as for the old protocol's handling of EOFException and
IOException.
> 
> 
> Diffs
> -----
> 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/GenericProtocolServerConnection.java
cd1647a 
> 
> 
> Diff: https://reviews.apache.org/r/61829/diff/1/
> 
> 
> Testing
> -------
> 
> as this just affects logging behavior there are no new unit tests.  I verified that the
behavior is correct with the manual test used to reproduce GEODE-3409 (my other review that
is currently open).
> 
> precheckin is running now.
> 
> 
> Thanks,
> 
> Bruce Schuchardt
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message