geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pdxrunner <...@git.apache.org>
Subject [GitHub] geode pull request #730: GEODE-3472: Remove a great deal of commented-out co...
Date Wed, 23 Aug 2017 16:37:08 GMT
Github user pdxrunner commented on a diff in the pull request:

    https://github.com/apache/geode/pull/730#discussion_r134804772
  
    --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/result/AbstractResultData.java
---
    @@ -147,11 +147,10 @@ public ResultData addAsFile(String fileName, String fileContents,
String message
     
       public ResultData addAsFile(String fileName, byte[] data, int fileType, String message,
           boolean addTimeStampToName) {
    -    byte[] bytes = data;
    --- End diff --
    
    I stand corrected. I confused myself with past experiences with other languages.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message