geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From galen-pivotal <...@git.apache.org>
Subject [GitHub] geode pull request #719: GEODE-3447 Implement client authorization for the n...
Date Wed, 23 Aug 2017 00:54:45 GMT
Github user galen-pivotal commented on a diff in the pull request:

    https://github.com/apache/geode/pull/719#discussion_r134633950
  
    --- Diff: geode-core/src/main/java/org/apache/geode/security/StreamAuthorizer.java ---
    @@ -0,0 +1,19 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more contributor license
    + * agreements. See the NOTICE file distributed with this work for additional information
regarding
    + * copyright ownership. The ASF licenses this file to You under the Apache License, Version
2.0 (the
    + * "License"); you may not use this file except in compliance with the License. You may
obtain a
    + * copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software distributed under
the License
    + * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND,
either express
    + * or implied. See the License for the specific language governing permissions and limitations
under
    + * the License.
    + */
    +package org.apache.geode.security;
    +
    +public interface StreamAuthorizer {
    +  boolean authorize(ResourcePermission permissionRequested);
    --- End diff --
    
    We may need to refactor this at some point when operations start needing more than one
permission (which depends on whether write authorization implies read authorization), but
I think that's more than a failing of the security API than ours, and it should be possible
to do everything we need for the alpha anyways (no getAndSet yet).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message