geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jhuynh1 <...@git.apache.org>
Subject [GitHub] geode pull request #732: GEODE-3276: Managing race conditions while the send...
Date Tue, 22 Aug 2017 23:05:53 GMT
Github user jhuynh1 commented on a diff in the pull request:

    https://github.com/apache/geode/pull/732#discussion_r134622619
  
    --- Diff: geode-wan/src/main/java/org/apache/geode/internal/cache/wan/parallel/ParallelGatewaySenderImpl.java
---
    @@ -107,6 +107,9 @@ public void stop() {
           if (ev != null && !ev.isStopped()) {
             ev.stopProcessing();
           }
    +      if (ev != null && ev.getDispatcher() != null) {
    --- End diff --
    
    Is it possible to pull this check and shutdown into a method?  Looks like it's used a
few times throughout the code


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message