geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Darrel Schneider <dschnei...@pivotal.io>
Subject Re: Review Request 61722: GEODE-3047 Atomic creation flag is not set if the region is recoverd from the disk.
Date Tue, 22 Aug 2017 19:51:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61722/#review183507
-----------------------------------------------------------


Ship it!




Ship It!

- Darrel Schneider


On Aug. 18, 2017, 9:58 a.m., anilkumar gingade wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61722/
> -----------------------------------------------------------
> 
> (Updated Aug. 18, 2017, 9:58 a.m.)
> 
> 
> Review request for geode, Darrel Schneider, Eric Shu, Lynn Gallinat, and Nick Reich.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> While creating bucket region, to satisfy the redudndancy copies the bucket regions
> are created on all available nodes. The initialization (setting persistentIDs) of
> these buckets are done after creating buckets on all the nodes. This introduced
> a race condition for the bucket region which are recovered from the disk to
> exchange thier old id with the peer node resulting in ConflictingPersistentData
> Exception.
> 
> The changes are done so that the regions persistent ids are set as soon as they
> are created/initialized.
> 
> 
> Diffs
> -----
> 
>   geode-core/src/main/java/org/apache/geode/internal/cache/BucketPersistenceAdvisor.java
367bb75e9 
>   geode-core/src/test/java/org/apache/geode/internal/cache/BucketPersistenceAdvisorTest.java
PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/61722/diff/1/
> 
> 
> Testing
> -------
> 
> added new unit test.
> run PartitionedRegionSingleHopDUnitTest.testClientMetadataForPersistentPrs 1400 times
> 
> 
> Thanks,
> 
> anilkumar gingade
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message