geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From galen-pivotal <...@git.apache.org>
Subject [GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests
Date Tue, 22 Aug 2017 00:05:48 GMT
Github user galen-pivotal commented on a diff in the pull request:

    https://github.com/apache/geode/pull/716#discussion_r134023037
  
    --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionFactory.java
---
    @@ -49,20 +48,13 @@ private synchronized void initializeAuthenticatorsMap() {
       }
     
       private synchronized ClientProtocolMessageHandler initializeMessageHandler() {
    --- End diff --
    
    The return value of this method is being ignored. Perhaps it should return `void`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message