geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Patrick Rhomberg <prhomb...@pivotal.io>
Subject Re: Review Request 61802: GEODE-3445: Add gfsh connect option --skip-ssl-validation
Date Mon, 21 Aug 2017 21:51:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61802/#review183401
-----------------------------------------------------------




geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ConnectCommand.java
Lines 120 (patched)
<https://reviews.apache.org/r/61802/#comment259420>

    Would it be better to clarify here `"When connecting via HTTP, connects using 1-way SSL
validation rather than 2-way SSL validation."`?


- Patrick Rhomberg


On Aug. 21, 2017, 9:06 p.m., Jared Stewart wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61802/
> -----------------------------------------------------------
> 
> (Updated Aug. 21, 2017, 9:06 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Patrick
Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> GEODE-3445: Add gfsh connect option --skip-ssl-validation
> 
> 
> Diffs
> -----
> 
>   geode-assembly/src/test/java/org/apache/geode/management/GfshConnectToLocatorWithSSLAcceptanceTest.java
PRE-CREATION 
>   geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/GfshRule.java fa25f14328d2cc56b2e0b64d834ed88dde082e8f

>   geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/GfshScript.java
52ef0d35a176c6522664eb18449d1c4b635f16a6 
>   geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ConnectCommand.java
274f61c1f304576f8d8db1d5289875ecea706962 
> 
> 
> Diff: https://reviews.apache.org/r/61802/diff/1/
> 
> 
> Testing
> -------
> 
> Precheckin running
> 
> 
> Thanks,
> 
> Jared Stewart
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message