geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From upthewaterspout <...@git.apache.org>
Subject [GitHub] geode pull request #712: GEODE-3434: Allow the modules to be interoperable w...
Date Thu, 17 Aug 2017 21:00:26 GMT
Github user upthewaterspout commented on a diff in the pull request:

    https://github.com/apache/geode/pull/712#discussion_r133827419
  
    --- Diff: extensions/geode-modules/src/main/java/org/apache/geode/modules/session/catalina/DeltaSession.java
---
    @@ -586,6 +610,20 @@ public int getSizeInBytes() {
         return serializedAttributes;
       }
     
    +  protected ConcurrentMap getAttributes() {
    +    try {
    +      Field field = getAttributesFieldObject();
    +      field.setAccessible(true);
    +      Map oldMap = (Map) field.get(this);
    +      ConcurrentMap newMap = new ConcurrentHashMap();
    --- End diff --
    
    Why do we need to copy the map here? I think the attributes field is always set to a ConcurrentHashMap,
even though in tomcat 6 the field was of type map.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message