geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Patrick Rhomberg <prhomb...@pivotal.io>
Subject Re: Review Request 61694: GEODE-3235: Deploy jar registers functions which extend FunctionAdapter
Date Wed, 16 Aug 2017 18:41:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61694/#review183049
-----------------------------------------------------------




geode-core/src/main/java/org/apache/geode/internal/DeployedJar.java
Lines 19-54 (original), 17-52 (patched)
<https://reviews.apache.org/r/61694/#comment259040>

    A few imports need reordering.
    
    ```
    geode-core/src/main/java/org/apache/geode/internal/DeployedJar.java
    geode-core/src/main/java/org/apache/geode/management/internal/deployment/FunctionScanner.java
    geode-core/src/test/resources/org/apache/geode/management/internal/deployment/AbstractImplementsFunction.java
    geode-core/src/test/resources/org/apache/geode/management/internal/deployment/AnnotatedFunction.java
    ```


- Patrick Rhomberg


On Aug. 16, 2017, 6:12 p.m., Jared Stewart wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61694/
> -----------------------------------------------------------
> 
> (Updated Aug. 16, 2017, 6:12 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Patrick
Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> GEODE-3235: Deploy jar registers functions which extend FunctionAdapter
> - Extract FunctionScanner class
> - Add scanning for FunctionAdapter in addition to Function
> - Add test to expose GEODE-3429
> 
> 
> Diffs
> -----
> 
>   geode-core/src/main/java/org/apache/geode/internal/DeployedJar.java 037ef9ee96f6a01927c6b2c429f186e4eab285be

>   geode-core/src/main/java/org/apache/geode/management/internal/deployment/FunctionScanner.java
PRE-CREATION 
>   geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/DeployCommandFunctionRegistrationDUnitTest.java
PRE-CREATION 
>   geode-core/src/test/java/org/apache/geode/management/internal/deployment/FunctionScannerTest.java
PRE-CREATION 
>   geode-core/src/test/resources/org/apache/geode/management/internal/deployment/AbstractExtendsFunctionAdapter.java
PRE-CREATION 
>   geode-core/src/test/resources/org/apache/geode/management/internal/deployment/AbstractImplementsFunction.java
PRE-CREATION 
>   geode-core/src/test/resources/org/apache/geode/management/internal/deployment/AnnotatedFunction.java
PRE-CREATION 
>   geode-core/src/test/resources/org/apache/geode/management/internal/deployment/ConcreteExtendsAbstractExtendsFunctionAdapter.java
PRE-CREATION 
>   geode-core/src/test/resources/org/apache/geode/management/internal/deployment/ConcreteExtendsAbstractImplementsFunction.java
PRE-CREATION 
>   geode-core/src/test/resources/org/apache/geode/management/internal/deployment/ExtendsAbstractFunction.java
PRE-CREATION 
>   geode-core/src/test/resources/org/apache/geode/management/internal/deployment/ExtendsFunctionAdapter.java
PRE-CREATION 
>   geode-core/src/test/resources/org/apache/geode/management/internal/deployment/ImplementsFunction.java
PRE-CREATION 
>   geode-junit/src/main/java/org/apache/geode/test/compiler/JarBuilder.java beea476d6a587bc0dcc434a03ea8b6beb53b449e

>   geode-junit/src/main/java/org/apache/geode/test/compiler/JavaCompiler.java 844960522726981fd3895caf336aef27de462485

> 
> 
> Diff: https://reviews.apache.org/r/61694/diff/1/
> 
> 
> Testing
> -------
> 
> precheckin running
> 
> 
> Thanks,
> 
> Jared Stewart
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message