geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kirk Lund <kirk.l...@gmail.com>
Subject Re: Review Request 61671: GEODE-3328: fix testAddGemFirePropertyFileToCommandLineNew on Windows
Date Tue, 15 Aug 2017 21:54:54 GMT


> On Aug. 15, 2017, 9:38 p.m., Ken Howe wrote:
> > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/GfshCommandJUnitTest.java
> > Line 411 (original), 411 (patched)
> > <https://reviews.apache.org/r/61671/diff/1/?file=1798156#file1798156line411>
> >
> >     Why was this test renamed? Not really a problem but on the surface looks unneeded.

Oops that was caused by me have both versions of the test in the class briefly. I'll remove
"New"


- Kirk


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61671/#review182999
-----------------------------------------------------------


On Aug. 15, 2017, 7:29 p.m., Kirk Lund wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61671/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2017, 7:29 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Jared Stewart, and Ken Howe.
> 
> 
> Bugs: GEODE-3328
>     https://issues.apache.org/jira/browse/GEODE-3328
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> I had to temporarily revert Jinmei's fix for GEODE-3328 in order to fully revert Emily's
refactorings of GFSH commands. This commit reintroduces her fix with minor tweak to get it
to work without Emily's changes.
> 
> 
> Diffs
> -----
> 
>   geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/GfshCommandJUnitTest.java
da60c7aa481954be0acc8c7e2b88717cf8bc9c37 
> 
> 
> Diff: https://reviews.apache.org/r/61671/diff/1/
> 
> 
> Testing
> -------
> 
> precheckin in progress
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message