geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pivotal-amurmann <...@git.apache.org>
Subject [GitHub] geode pull request #700: GEODE-3386 - Make KeyedErrorResponse & ErrorRespons...
Date Mon, 14 Aug 2017 16:51:23 GMT
Github user pivotal-amurmann commented on a diff in the pull request:

    https://github.com/apache/geode/pull/700#discussion_r133001811
  
    --- Diff: geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/PutAllRequestOperationHandler.java
---
    @@ -79,9 +81,10 @@
       private BasicTypes.KeyedErrorResponse buildAndLogKeyedError(BasicTypes.Entry entry,
           ProtocolErrorCode errorCode, String message, Exception ex) {
         logger.error(message, ex);
    -    BasicTypes.ErrorResponse errorResponse = BasicTypes.ErrorResponse.newBuilder()
    -        .setErrorCode(errorCode.codeValue).setMessage(message).build();
    -    return BasicTypes.KeyedErrorResponse.newBuilder().setKey(entry.getKey()).setError(errorResponse)
    +
    +    return BasicTypes.KeyedErrorResponse.newBuilder().setKey(entry.getKey())
    +        .setError(
    +            BasicTypes.Error.newBuilder().setErrorCode(errorCode.codeValue).setMessage(message))
    --- End diff --
    
    yeah it did 😔
    Tried to reformat it, but it insists on making this bad.
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message