geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kohlmu-pivotal <...@git.apache.org>
Subject [GitHub] geode pull request #707: GEODE-3412: Add simple authentication flow to proto...
Date Fri, 11 Aug 2017 17:19:03 GMT
Github user kohlmu-pivotal commented on a diff in the pull request:

    https://github.com/apache/geode/pull/707#discussion_r132737182
  
    --- Diff: geode-core/src/main/java/org/apache/geode/distributed/ConfigurationProperties.java
---
    @@ -1378,6 +1379,18 @@
        */
       String NAME = "name";
       /**
    +   * The authentication mode for the protobuf client-server protocol.
    +   *
    +   * </p>
    +   * <U>Description</U>: Specifies the authentication mode used by the geode-protobuf
module.
    +   * </p>
    +   * <U>Default</U>: "NOOP"
    +   * </p>
    +   * <U>Allowed values</U>: "NOOP" "SIMPLE"
    +   */
    +  @Experimental
    +  String PROTOBUF_PROTOCOL_AUTHENTICATION_MODE = "protobuf-protocol-authentication-mode";
    --- End diff --
    
    This property is misleading. It is NOT a protobuf specific authentication mode. It is
merely an authentication mechanism that uses protobuf underneath the covers.
    1) A different property name is to be used
    2) With this property, the feature toggle should also maybe be removed??!!? One cannot
live without the other


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message