geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kirklund <...@git.apache.org>
Subject [GitHub] geode pull request #699: GEODE-3413: overhaul launcher and process classes a...
Date Thu, 10 Aug 2017 18:30:19 GMT
Github user kirklund commented on a diff in the pull request:

    https://github.com/apache/geode/pull/699#discussion_r132532669
  
    --- Diff: geode-core/src/test/java/org/apache/geode/internal/process/AbstractProcessStreamReaderIntegrationTest.java
---
    @@ -0,0 +1,234 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more contributor license
    + * agreements. See the NOTICE file distributed with this work for additional information
regarding
    + * copyright ownership. The ASF licenses this file to You under the Apache License, Version
2.0 (the
    + * "License"); you may not use this file except in compliance with the License. You may
obtain a
    + * copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software distributed under
the License
    + * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND,
either express
    + * or implied. See the License for the specific language governing permissions and limitations
under
    + * the License.
    + */
    +package org.apache.geode.internal.process;
    +
    +import static java.util.concurrent.TimeUnit.MILLISECONDS;
    +import static org.apache.commons.lang.SystemUtils.LINE_SEPARATOR;
    +
    +import java.io.File;
    +import java.util.ArrayList;
    +import java.util.Arrays;
    +import java.util.List;
    +
    +import org.awaitility.Awaitility;
    +import org.awaitility.core.ConditionFactory;
    +import org.junit.After;
    +
    +import org.apache.geode.internal.util.StopWatch;
    +
    +/**
    + * Abstract base class for functional integration testing of {@link ProcessStreamReader}.
    + */
    +public abstract class AbstractProcessStreamReaderIntegrationTest {
    +
    +  /** Timeout to join to a running ProcessStreamReader thread */
    +  protected static final int READER_JOIN_TIMEOUT_MILLIS = 20 * 1000;
    +
    +  /** Sleep timeout for {@link ProcessSleeps} instead of sleeping Long.MAX_VALUE */
    +  private static final int PROCESS_FAILSAFE_TIMEOUT_MILLIS = 10 * 60 * 1000;
    +
    +  /** Additional time for launched processes to live before terminating */
    +  private static final int PROCESS_TIME_TO_LIVE_MILLIS = 3 * 500;
    +
    +  /** Timeout to wait for a new {@link ProcessStreamReader} to be running */
    +  private static final int WAIT_FOR_READER_IS_RUNNING_TIMEOUT_MILLIS = 20 * 1000;
    +
    +  protected Process process;
    +  protected ProcessStreamReader stderr;
    +  protected ProcessStreamReader stdout;
    +
    +  @After
    +  public void afterProcessStreamReaderTestCase() throws Exception {
    +    if (stderr != null) {
    +      stderr.stop();
    +    }
    +    if (stdout != null) {
    +      stdout.stop();
    +    }
    +    if (process != null) {
    +      try {
    +        process.getErrorStream().close();
    +        process.getInputStream().close();
    +        process.getOutputStream().close();
    +      } finally {
    +        // this is async and can require more than 10 seconds on slower machines
    +        process.destroy();
    +      }
    +    }
    +  }
    +
    +  protected ConditionFactory await() {
    +    return Awaitility.await().atMost(WAIT_FOR_READER_IS_RUNNING_TIMEOUT_MILLIS, MILLISECONDS);
    +  }
    +
    +  protected static boolean isAlive(final Process process) {
    --- End diff --
    
    Done.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message