geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pdxrunner <...@git.apache.org>
Subject [GitHub] geode pull request #699: GEODE-3413: overhaul launcher and process classes a...
Date Thu, 10 Aug 2017 17:42:16 GMT
Github user pdxrunner commented on a diff in the pull request:

    https://github.com/apache/geode/pull/699#discussion_r132515331
  
    --- Diff: geode-core/src/main/java/org/apache/geode/distributed/ServerLauncher.java ---
    @@ -810,9 +819,6 @@ public void setStatus(final String statusMessage) {
                 LocalizedStrings.Launcher_Command_START_PID_UNAVAILABLE_ERROR_MESSAGE.toLocalizedString(
                     getServiceName(), getId(), getWorkingDirectory(), e.getMessage()),
                 e);
    -      } catch (ClusterConfigurationNotAvailableException e) {
    -        failOnStart(e);
    -        throw e;
           } catch (RuntimeException e) {
             failOnStart(e);
    --- End diff --
    
    Opportunity to combine catch blocks?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message