geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pdxrunner <...@git.apache.org>
Subject [GitHub] geode pull request #699: GEODE-3413: overhaul launcher and process classes a...
Date Wed, 09 Aug 2017 23:03:15 GMT
Github user pdxrunner commented on a diff in the pull request:

    https://github.com/apache/geode/pull/699#discussion_r132325049
  
    --- Diff: geode-core/src/main/java/org/apache/geode/distributed/LocatorLauncher.java ---
    @@ -1075,8 +1082,7 @@ private LocatorState stopWithWorkingDirectory() {
         try {
           final ProcessController controller =
               new ProcessControllerFactory().createProcessController(this.controllerParameters,
    -              new File(getWorkingDirectory()), ProcessType.LOCATOR.getPidFileName(),
    -              READ_PID_FILE_TIMEOUT_MILLIS, TimeUnit.MILLISECONDS);
    +              new File(getWorkingDirectory()), ProcessType.LOCATOR.getPidFileName());
           parsedPid = controller.getProcessId();
     
           // NOTE in-process request will go infinite loop unless we do the following
    --- End diff --
    
    There are several opportunities for collapsing multiple catch blocks in this class, such
as the try/catch that starts at line 1082


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message