geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pdxrunner <...@git.apache.org>
Subject [GitHub] geode pull request #699: GEODE-3413: overhaul launcher and process classes a...
Date Wed, 09 Aug 2017 21:49:51 GMT
Github user pdxrunner commented on a diff in the pull request:

    https://github.com/apache/geode/pull/699#discussion_r132303567
  
    --- Diff: geode-core/src/test/java/org/apache/geode/internal/process/BlockingProcessStreamReaderWindowsTest.java
---
    @@ -0,0 +1,97 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more contributor license
    + * agreements. See the NOTICE file distributed with this work for additional information
regarding
    + * copyright ownership. The ASF licenses this file to You under the Apache License, Version
2.0 (the
    + * "License"); you may not use this file except in compliance with the License. You may
obtain a
    + * copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software distributed under
the License
    + * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND,
either express
    + * or implied. See the License for the specific language governing permissions and limitations
under
    + * the License.
    + */
    +package org.apache.geode.internal.process;
    +
    +import static org.apache.geode.internal.lang.SystemUtils.isWindows;
    +import static org.assertj.core.api.Assertions.assertThat;
    +import static org.assertj.core.api.Assertions.assertThatThrownBy;
    +import static org.junit.Assume.assumeTrue;
    +
    +import java.util.concurrent.ExecutorService;
    +import java.util.concurrent.Executors;
    +import java.util.concurrent.Future;
    +import java.util.concurrent.TimeUnit;
    +import java.util.concurrent.TimeoutException;
    +
    +import org.junit.After;
    +import org.junit.Before;
    +import org.junit.Test;
    +import org.junit.experimental.categories.Category;
    +
    +import org.apache.geode.test.junit.categories.IntegrationTest;
    +
    +/**
    + * Functional integration test {@link #hangsOnWindows} for BlockingProcessStreamReader
which
    + * verifies TRAC #51967 on Windows. The hang is caused by a JDK bug in which a thread
invoking
    --- End diff --
    
    The bug number reference is not meaningful in the context of the geode community. I suggest
rewording this to remove the specific reference while still describing the the nature of the
bug that this test verifies the fix for.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message