geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From PurelyApplied <...@git.apache.org>
Subject [GitHub] geode pull request #699: GEODE-3413: overhaul launcher and process classes a...
Date Wed, 09 Aug 2017 21:38:29 GMT
Github user PurelyApplied commented on a diff in the pull request:

    https://github.com/apache/geode/pull/699#discussion_r132312668
  
    --- Diff: geode-core/src/main/java/org/apache/geode/distributed/LocatorLauncher.java ---
    @@ -1848,8 +1884,7 @@ public LocatorLauncher build() {
         private final String name;
     
         Command(final String name, final String... options) {
    -      assert !StringUtils
    -          .isBlank(name) : "The name of the locator launcher command must be specified!";
    +      assert !isBlank(name) : "The name of the locator launcher command must be specified!";
    --- End diff --
    
    As long as we're touching this, we could consider using `isNotBlank` for better readability.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message