geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jinmei Liao <jil...@pivotal.io>
Subject Re: Review Request 61506: GEODE-3328: refactor ConnectCommand
Date Wed, 09 Aug 2017 19:02:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61506/
-----------------------------------------------------------

(Updated Aug. 9, 2017, 7:02 p.m.)


Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Patrick Rhomberg.


Repository: geode


Description
-------

* connect command will prompt for missing ssl configs if ssl is implied.
* command ssl options will override the properties loaded in the file and prompt for missing
ones if ssl is defined using the ssl-* prefix
* reworked the SSLConfigFactory to not use cached sslConfig when passing in a Properties object


Diffs
-----

  geode-core/src/main/java/org/apache/geode/distributed/ConfigurationProperties.java 91a6443b8fd98874feb9f17cf15b36826d7982c3

  geode-core/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpClient.java
d4068910779c93b800d795d7f31f49a722ce6576 
  geode-core/src/main/java/org/apache/geode/internal/net/SSLConfigurationFactory.java 4b98617465d282fd9ff50cf551a66d4359b4111d

  geode-core/src/main/java/org/apache/geode/management/internal/JmxManagerLocatorRequest.java
eb71d38e4f893b0435d99b2192256fb559751b00 
  geode-core/src/main/java/org/apache/geode/management/internal/beans/BeanUtilFuncs.java 16d45bc719817782d84ae7e3da876fb9ed4a77bb

  geode-core/src/main/java/org/apache/geode/management/internal/cli/AbstractCliAroundInterceptor.java
3e1357dad711c134cc45e5415b132dfdde92d93f 
  geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ConnectCommand.java
be556a447d862144e453f69809a2de67ee00b654 
  geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ShellCommands.java
1aea253ff72dfd2bd89754e862cf222754286a94 
  geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/StartLocatorCommand.java
5b289a545e2d324bfa516cf1b05f8df641bc8a36 
  geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/UserInputProperty.java
PRE-CREATION 
  geode-core/src/main/java/org/apache/geode/management/internal/cli/i18n/CliStrings.java 58c8ef79c70f789d10d0a6e95cb24b510aa014a0

  geode-core/src/main/java/org/apache/geode/management/internal/cli/shell/Gfsh.java a69ce36afa6762890edcfb58f48bd8eddd27be65

  geode-core/src/main/java/org/apache/geode/management/internal/cli/shell/JmxOperationInvoker.java
7ae7c3b0f7d85aae1a8d16ba0fa7d9b80683bdfd 
  geode-core/src/main/java/org/apache/geode/management/internal/cli/util/GfshConsoleReader.java
9251d7e127a085e3bdb9bfcffc6c706b50b042dd 
  geode-core/src/test/java/org/apache/geode/internal/net/SSLConfigurationFactoryJUnitTest.java
31c2469a6ef7d9a1db9f2803b0b5bd9adfb5971c 
  geode-core/src/test/java/org/apache/geode/management/ConnectToLocatorSSLDUnitTest.java 866f4ef43dd1c583df210caa491cdd0ef8a3b84a

  geode-core/src/test/java/org/apache/geode/management/ConnectToLocatorWithLegacySSLDUnitTest.java
d7db4897d58d318496c1ba990c792ba94f77c81e 
  geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ConnectCommandTest.java
PRE-CREATION 
  geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/UserInputPropertyTest.java
PRE-CREATION 
  geode-cq/src/test/java/org/apache/geode/management/CacheServerManagementDUnitTest.java 2cd69ddc619a68fb151e6574bace7418a7d58d10

  geode-web/src/test/java/org/apache/geode/management/internal/cli/commands/ConnectCommandIntegrationTest.java
PRE-CREATION 
  geode-web/src/test/java/org/apache/geode/management/internal/cli/commands/ConnectCommandWithSSLTest.java
PRE-CREATION 
  geode-web/src/test/java/org/apache/geode/management/internal/cli/commands/ConnectCommandWithSecurityTest.java
PRE-CREATION 
  geode-web/src/test/java/org/apache/geode/management/internal/cli/commands/ConnectToLocatorSSLOverHttpTest.java
e5b8d25ae4349e19c252c4d364d0a3c50edeeb54 


Diff: https://reviews.apache.org/r/61506/diff/2/


Testing (updated)
-------

precheckin all Green


Thanks,

Jinmei Liao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message