geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From PurelyApplied <...@git.apache.org>
Subject [GitHub] geode pull request #693: GEODE-3268: Refactoring RegionCommands
Date Mon, 07 Aug 2017 22:51:06 GMT
Github user PurelyApplied commented on a diff in the pull request:

    https://github.com/apache/geode/pull/693#discussion_r131776451
  
    --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DescribeRegionCommand.java
---
    @@ -359,7 +272,7 @@ private boolean writeFixedPartitionAttributesToTable(TabularResultData
table,
             fpaBuilder.append(fpa.getNumBuckets());
     
             if (!isTypeAdded) {
    -          type = attributeType;
    +          type = "";
    --- End diff --
    
    I agree with the removal of a constant parameter, but in this case, we're not distinguishing
between `type = "";` here vs `type = blank; // = ""` a few lines below. 
     These could be removed altogether, with `""` passed directly to the `writeAttributeToTable`
call at the end of this method.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message