geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From YehEmily <...@git.apache.org>
Subject [GitHub] geode pull request #685: GEODE-3261: Refactoring GfshHelpCommands
Date Mon, 07 Aug 2017 16:44:46 GMT
Github user YehEmily commented on a diff in the pull request:

    https://github.com/apache/geode/pull/685#discussion_r131705221
  
    --- Diff: geode-core/src/test/java/org/apache/geode/management/internal/cli/help/HelperIntegrationTest.java
---
    @@ -34,7 +36,7 @@
       public static void beforeClass() {
         helper = new Helper();
         // use GfshHelpCommand for testing
    -    Method[] methods = GfshHelpCommands.class.getMethods();
    +    Method[] methods = GfshHelpCommand.class.getMethods();
    --- End diff --
    
    Good idea - thank you for your feedback! I don't think the original test ever actually
tested the hint command, so I wrote two completely new tests: `HelperIntegrationTest.TestHintWithInput`
and `HelperIntegrationTest.TestHintWithoutInput`. PR has also been updated!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message