geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pdxrunner <...@git.apache.org>
Subject [GitHub] geode pull request #685: GEODE-3261: Refactoring GfshHelpCommands
Date Fri, 04 Aug 2017 20:26:43 GMT
Github user pdxrunner commented on a diff in the pull request:

    https://github.com/apache/geode/pull/685#discussion_r131479491
  
    --- Diff: geode-core/src/test/java/org/apache/geode/management/internal/cli/help/HelperIntegrationTest.java
---
    @@ -34,7 +36,7 @@
       public static void beforeClass() {
         helper = new Helper();
         // use GfshHelpCommand for testing
    -    Method[] methods = GfshHelpCommands.class.getMethods();
    +    Method[] methods = GfshHelpCommand.class.getMethods();
    --- End diff --
    
    With the original multiple-command class being split, this test now only checks one of
the two commands. Add a second test for GfshHintCommand. I would add it to this test class,
refactoring the beforeClass functionality into separate imnplementations in each test.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message