geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Eric Shu <e...@pivotal.io>
Subject Review Request 61281: GEODE-3379 Geode transaction may commit on a secondary bucket after bucket rebalance
Date Tue, 01 Aug 2017 21:41:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61281/
-----------------------------------------------------------

Review request for geode, anilkumar gingade, Darrel Schneider, Lynn Gallinat, and Nick Reich.


Bugs: GEODE-3379
    https://issues.apache.org/jira/browse/GEODE-3379


Repository: geode


Description
-------

Current geode commit method only hold primary bucket lock when the txRegion is a primary bucket.
However, in between the tx operation and commit, a rebalance could cause primary bucket to
move. In this case, commit should detect the primary bucket has been moved and throw TransactionDataRebalancedException.


Diffs
-----

  geode-core/src/main/java/org/apache/geode/internal/cache/TXState.java 2c8c28b 
  geode-core/src/test/java/org/apache/geode/disttx/PRDistTXDUnitTest.java 77bf740 
  geode-core/src/test/java/org/apache/geode/disttx/PRDistTXWithVersionsDUnitTest.java 9ab5145

  geode-core/src/test/java/org/apache/geode/internal/cache/execute/PRTransactionDUnitTest.java
6578baa 


Diff: https://reviews.apache.org/r/61281/diff/1/


Testing
-------

Ongoing precheckin.


Thanks,

Eric Shu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message