geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jared Stewart <jstew...@pivotal.io>
Subject Re: Review Request 61231: GEODE-3328: simply extract connect command from ShellCommand
Date Tue, 01 Aug 2017 00:32:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61231/#review181866
-----------------------------------------------------------


Ship it!




Ship It!

- Jared Stewart


On July 28, 2017, 8:41 p.m., Jinmei Liao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61231/
> -----------------------------------------------------------
> 
> (Updated July 28, 2017, 8:41 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Patrick
Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> I am working on GEM-1575 which involves prompting for ssl configuration properties when
connecting to the cluster. So I refactoring the ConnectCommand before doing that.
> This is the first step: simply extracting the command to its separate class without any
refactor at all
> 
> GEODE-3328: simply extract connect command from ShellCommand
> 
> 
> Diffs
> -----
> 
>   geode-core/src/main/java/org/apache/geode/internal/util/PasswordUtil.java ac0b8459e1cd8f399eed5e98bd9d5fbd4953f9c3

>   geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ConnectCommand.java
PRE-CREATION 
>   geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ShellCommands.java
d5e1b27715420818e9a63c9bd467d771e5ee20e3 
>   geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/StartLocatorCommand.java
10dc0db871898b4fe95027baeacfc72f0e16d4a3 
>   geode-core/src/main/java/org/apache/geode/management/internal/cli/util/GfshConsoleReader.java
80a20e6d075f2b7c9202df96f36aa4c99c445e04 
>   geode-core/src/test/java/org/apache/geode/internal/util/PasswordUtilJUnitTest.java
8051c5671650ad4f4756f9f614778d1ae1387fa7 
> 
> 
> Diff: https://reviews.apache.org/r/61231/diff/1/
> 
> 
> Testing
> -------
> 
> precheckin running
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message