Mailing-List: contact dev-help@geode.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@geode.apache.org
From: YehEmily <git@git.apache.org>
To: dev@geode.apache.org
Reply-To: dev@geode.apache.org
References: <git-pr-651-geode@git.apache.org>
In-Reply-To: <git-pr-651-geode@git.apache.org>
Subject: [GitHub] geode pull request #651: GEODE-3230: Cleaning up unused (Cli)Strings
Content-Type: text/plain
Message-Id: <20170726181705.F36E3E02FE@git1-us-west.apache.org>
Date: Wed, 26 Jul 2017 18:17:05 +0000 (UTC)
archived-at: Wed, 26 Jul 2017 18:17:09 -0000

Github user YehEmily commented on a diff in the pull request:

    https://github.com/apache/geode/pull/651#discussion_r129654481
  
    --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommands.java ---
    @@ -639,29 +639,34 @@ public Result compactOfflineDiskStore(
           String errorString = CliStrings.format(
               CliStrings.COMPACT_OFFLINE_DISK_STORE__MSG__ERROR_WHILE_COMPACTING_DISKSTORE_0_WITH_1_REASON_2,
               diskStoreName, fieldsMessage);
    -      result = ResultBuilder.createUserErrorResult(errorString);
    +      result = ResultBuilder.createUserErrorResult(CliStrings.format(
    --- End diff --
    
    Good catch! I fixed this and updated the PR. Thank you!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---